fix 12 typos #3842
Closed
fix 12 typos #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RoboSchmied <[email protected]>
|
Hi, it looks like your PR changes the name of one function in ArduinoJson-v6. Actually this file is not a creation of WLED authors, but just a copy&paste dependency library. The original lib is here: https://github.com/bblanchon/ArduinoJson Can you confirm that your change is agreed by the authors of ArduinoJSON? I'd rather not get into a situation where we might want to update the dependency, but it's not possible any more because in WLED the name of one function was changed/refactored to correct the spelling. |
|
I see no added value from this PR. Variable and function names may not be English at all. |
|
Closed, as this PR creates a risk of becoming incompatible with upstream ArduinoJson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typo: endianess --> endianness