Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct start index for Art-Net in proxy mode #3863

Open
wants to merge 1 commit into
base: 0_15
Choose a base branch
from

Conversation

askask
Copy link

@askask askask commented Mar 29, 2024

Art-Net data doesn't contain a start byte. This is currently only taken into account when using regular LED output.
With this commit it also works when using DMX proxy mode.

@softhack007
Copy link
Collaborator

@troyhacks, @netmindz: If I remember correctly, you are regularly working with Art-Net? Would like to get your thoughts on this PR.

@troyhacks
Copy link
Contributor

I think I understand it - it's just aligning incoming Art-Net/E1.31 data so channels from an Art-Net packet hits DMX output on the correct channel.

I haven't used this feature, but I think it's safe to merge. Good catch, @askask!

@askask askask marked this pull request as draft April 8, 2024 21:35
@askask askask marked this pull request as ready for review April 9, 2024 01:33
Copy link

github-actions bot commented Aug 7, 2024

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for contributing to WLED! ❤️

@github-actions github-actions bot added the stale This issue will be closed soon because of prolonged inactivity label Aug 7, 2024
@blazoncek blazoncek added keep This issue will never become stale/closed automatically and removed stale This issue will be closed soon because of prolonged inactivity labels Aug 7, 2024
@netmindz
Copy link
Collaborator

netmindz commented Aug 8, 2024

I'm not sure WLED is really appropriate for trying to be a an ArtNet/sACN to DMX (wired) convertor, but if has that feature it should certainly map the right values to the right channel.

If we are looking for confirmation of fix before merge with actual hardware I can probably rustle something up.

For future reference I would always recommend using a dedicated esp32 if you want such bridge from wireless to wired DMX, lighting desk send a universe at up to 44 Hz which WLED can't provide so you will lose frames and moving heads might behave erratically when getting a slow and inconsistent update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting testing bug keep This issue will never become stale/closed automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants