-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Segment FX #4124
Open
DedeHai
wants to merge
11
commits into
Aircoookie:0_15
Choose a base branch
from
DedeHai:0_15_copy_segment
base: 0_15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Copy Segment FX #4124
Commits on Sep 1, 2024
-
Added FX to copy a segment in 1D or 2D
- copies the source segment - brightness of segment is relative to source segment - optionally shifts the color hue - invert, transpose, mirror work - if source or targets do not match in size, smallest size is copied - unused pixels fade to black (allows overlapping segments) - if invalid source ID is set, segment just fades to black - added a rgb2hsv conversion function as the fastled variant is inaccurate and buggy note: 1D to 2D and vice versa is not supported
Configuration menu - View commit details
-
Copy full SHA for 434ba3f - Browse repository at this point
Copy the full SHA 434ba3fView commit details
Commits on Sep 4, 2024
-
target segment now also copies the source settings (mirror, grouping, spacing, transpose) so the target looks exactly like the source. inverting can still be set independently. note: the bug in line 214 of FX_2Dfcn.cpp missing `start` needs to be fixed for it to work properly in 2D.
Configuration menu - View commit details
-
Copy full SHA for 24df6bf - Browse repository at this point
Copy the full SHA 24df6bfView commit details
Commits on Sep 7, 2024
-
Update integrating new ideas as discussed
- added color adjust function with support for hue, lightness and brightness - colors can now be adjusted in hue, saturation and brightness - added `getRenderedPixelXY()` function (credit @willmmiles) - source is now accurately copied, even 1D->2D is possible - fix for segment offset not being zero in 2D in `getRenderedPixelXY()` - added checkmark to copy source grouping/spacing (may remove again) - tested many different scenarios, everything seems to work
Configuration menu - View commit details
-
Copy full SHA for 696f74b - Browse repository at this point
Copy the full SHA 696f74bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e0ceab - Browse repository at this point
Copy the full SHA 1e0ceabView commit details
Commits on Sep 8, 2024
-
- removed 'copy grouping/spacing' option - added 'Switch axis' instead (in 2D -> 1D copy this chooses x or y axis to be copied) - optimized for code size and speed by not using CRGB (where possible) and not returning struct in `rgb2hsv()`
Configuration menu - View commit details
-
Copy full SHA for 8aa82ab - Browse repository at this point
Copy the full SHA 8aa82abView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd8353a - Browse repository at this point
Copy the full SHA dd8353aView commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bdd8747 - Browse repository at this point
Copy the full SHA bdd8747View commit details -
rgb2hsv now returns the CHSV value instead of using a reference
added alias function to accept CRGB value. this is more versatile for future uses. also removed some whitespaces
Configuration menu - View commit details
-
Copy full SHA for df33a36 - Browse repository at this point
Copy the full SHA df33a36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7db1adc - Browse repository at this point
Copy the full SHA 7db1adcView commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24a424a - Browse repository at this point
Copy the full SHA 24a424aView commit details
Commits on Sep 25, 2024
-
Added HSV2RGB and RGB2HSV functions for higher accuracy conversions
- Bonus: saves over 1.2kB of flash -also added a struct to handle HSV with 16bit hue better (including some conversions, can be extended easily) - the functions are optimized for speed and flash use. They are faster and more accurate than what fastled offers (and use much less flash). - replaced colorHStoRGB() with a call to the new hsv2rgb() function, saving even more flash - the 16bit hue calculations result in an almost perfect conversion from RGB to HSV and back, the maximum error was 1/255 in the cases I tested.
Configuration menu - View commit details
-
Copy full SHA for a5807b5 - Browse repository at this point
Copy the full SHA a5807b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.