Fix release name macro expansion

[netmindz]

Fix for #4260

[softhack007]

Error: The path for one of the files in artifact is not valid: /WLED_0.15.0-b7_"ESP8266".bin. Contains the following character: Double quote "

@netmindz I think output_bins.py needs to be adjusted - might be that simply deleting any " and ' from the release_name before copy files might be sufficient.

[willmmiles]

The quote stripping needs to be inside the if below, in case it's not defined and _get_cpp_define_value returns None.

[blazoncek]

I'm wondering what's wrong with stringification? https://gcc.gnu.org/onlinedocs/gcc-4.8.5/cpp/Stringification.html

There are some other places that use TOSTRING() too.

[willmmiles]

I'm wondering what's wrong with stringification? https://gcc.gnu.org/onlinedocs/gcc-4.8.5/cpp/Stringification.html

There are some other places that use TOSTRING() too.

It macro-expands recursively -- there is no way to expand exactly once. Eg: -DESP32=Stuff -D WLED_RELEASE_NAME=ESP32 means that TOSTRING(WLED_RELEASE_NAME) expands to "Stuff" -- eg WLED_RELEASE_NAME->ESP32->Stuff. Since ESP32 happens to be #defined somewhere (FastLED, if nowhere else!), it expands to something unhelpful before it's converted to a string literal.

[blazoncek]

It macro-expands recursively -- there is no way to expand exactly once. Eg: -DESP32=Stuff -D WLED_RELEASE_NAME=ESP32 means that TOSTRING(WLED_RELEASE_NAME) expands to "Stuff" -- eg WLED_RELEASE_NAME->ESP32->Stuff. Since ESP32 happens to be #defined somewhere (FastLED, if nowhere else!), it expands to something unhelpful before it's converted to a string literal.

That explains 1 seen in builds.

So the simplest solution is to use something unique that has no ordinary/recursive counterpart. I.e. rename "ESP32" with "ESP32plain" in platformio.ini. IMO that's acceptable as no previous builds have "ESP32" (or "ESP8266") compiled in due to the recursion flaw.

This (adding unique WLED_RELEASE_NAME) would also help differentiate builds @Moustachauve wants to implement in his mobile app.

[netmindz]

It macro-expands recursively -- there is no way to expand exactly once. Eg: -DESP32=Stuff -D WLED_RELEASE_NAME=ESP32 means that TOSTRING(WLED_RELEASE_NAME) expands to "Stuff" -- eg WLED_RELEASE_NAME->ESP32->Stuff. Since ESP32 happens to be #defined somewhere (FastLED, if nowhere else!), it expands to something unhelpful before it's converted to a string literal.

That explains 1 seen in builds.

So the simplest solution is to use something unique that has no ordinary/recursive counterpart. I.e. rename "ESP32" with "ESP32plain" in platformio.ini. IMO that's acceptable as no previous builds have "ESP32" (or "ESP8266") compiled in due to the recursion flaw.

This (adding unique WLED_RELEASE_NAME) would also help differentiate builds @Moustachauve wants to implement in his mobile app.

My initial version of this PR changed the value to be WLED_ESP32, the removed the hard coded WLED from the rename python script, but that's a bigger change, hence swapping to @willmmiles suggestion for a smaller change

[blazoncek]

Or perhaps just:

#ifndef WLED_RELEASE_NAME
  #define WLED_RELEASE_NAME dev_release
#else
  #if WLED_RELEASE_NAME == ESP32 || WLED_RELEASE_NAME == ESP8266
    #error Wrong WLED_RELEASE_NAME.
  #endif
#endif