controller: Ensure completed streams are recorded before stopping #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the following from happening: 1. First scheduled backup is started 2. Backup time is changed 3. Basebackup from step 1 finishes 4. Daemon main loop stops controller 5. Config is reloaded 6. Daemon main loop starts controller 7. Controller does not load backups from object storage because last load happened fairly recently so backup from step 1 is not visible 8. New normalized backup time differs from previous one, as there are no backups new backup is created immediately 9. Basebackup from step 8 finishes 10. Completed streams are processed and list of backups is refreshed With this change step 10 happens at step 4 and no new backup is started in step 8 because there is already a known backup that is very recent.
|
Created as draft since this is speculative fix based on couple of log lines, didn't actually test in any way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the following from happening:
happened fairly recently so backup from step 1 is not visible
backups new backup is created immediately
With this change step 10 happens at step 4 and no new backup is started
in step 8 because there is already a known backup that is very recent.
About this change: What it does, why it matters
(all contributors please complete this section, including maintainers)