-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the exporter to support OpenSearch 2.9.0 #203
Conversation
Signed-off-by: Victor <[email protected]>
@vinylen Did you have a chance to check what is wrong with the upgrade? I will be back in office on Monday so I will have a look but does it pass on your end?
|
@lukas-vlcek I'm sorry i'm no Java developer so i don't really understand what is going wrong. I ran a local nix-shell with gradle + openjdk and got this output when running the command
|
There are some breaking changes in OpenSearch |
@vinylen Can you please give me privs so that I can add commits to your PR? git push vinylen remotes/vinylen/2.9.0
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:vinylen/prometheus-exporter-plugin-for-opensearch.git
! [remote rejected] vinylen/2.9.0 -> vinylen/2.9.0 (permission denied)
error: failed to push some refs to 'github.com:vinylen/prometheus-exporter-plugin-for-opensearch.git' Or I will have to open a new PR on my side (though I will use your upgrade commit I still prefer pushing to your PR). |
@lukas-vlcek I'm sorry, I'm away on vacation and I don't have my laptop with me. I tried to find something to change in GitHub mobile but I can't find anything. Looks like you might have to add your own PR, if you do, you are free to close this PR. Sorry for the inconvenience. |
Description
Simple version change to support OpenSearch 2.9.0
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.