Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

악기 브랜드,모델 엔티티 생성 #43

Merged
merged 2 commits into from
Feb 23, 2024
Merged

악기 브랜드,모델 엔티티 생성 #43

merged 2 commits into from
Feb 23, 2024

Conversation

tinon1004
Copy link
Contributor

🔥 Related Issue

🏃‍ Task

  • 악기 브랜드, 모델 엔티티 작성

📄 Reference

  • None

@tinon1004 tinon1004 requested a review from Wo-ogie February 22, 2024 10:35
@tinon1004 tinon1004 self-assigned this Feb 22, 2024
@tinon1004 tinon1004 added the enhancement New feature or request label Feb 22, 2024
Wo-ogie
Wo-ogie requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Wo-ogie Wo-ogie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. commit message 작성할 때 관련 issue 번호 붙여주세요(commit message에 대한 convention 참고). 이번에는 그냥 올리는거로 하고, 다음부터 신경써주시기 바랍니다.
  2. ERD 기준으로 created_at과 updated_at이 존재하는데, 이 부분에 대한 정의가 빠져있네요. TimeTrackedBaseEntity 상속받아서 구현 마쳐주세요.

@Wo-ogie Wo-ogie force-pushed the feature/#37-brand-model-entity branch from d241686 to a34895b Compare February 23, 2024 02:32
Wo-ogie
Wo-ogie approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Wo-ogie Wo-ogie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message는 타입: 이슈_번호 메시지_본문 순으로 작성해주시면 됩니다.
이번에는 제가 수정해두었습니다. 다음부터 참고 부탁드려요~

@Wo-ogie Wo-ogie merged commit dff2e5b into main Feb 23, 2024
1 check passed
@Wo-ogie Wo-ogie deleted the feature/#37-brand-model-entity branch February 23, 2024 02:35
Wo-ogie added a commit that referenced this pull request Feb 24, 2024
@Wo-ogie
Revert "Merge pull request #43 from Ajou-Hertz/feature/#37-brand-mode…
ffab82b 
…l-entity"

This reverts commit dff2e5b, reversing
changes made to 73d4d3a.
Wo-ogie added a commit that referenced this pull request Feb 24, 2024
@Wo-ogie
Revert "Merge pull request #43 from Ajou-Hertz/feature/#37-brand-mode…
9aa17a3 
…l-entity"

설계 변경으로 인하여 더 이상 필요 없어진 entity 제거
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wo-ogie Wo-ogie Wo-ogie approved these changes

Assignees

@tinon1004 tinon1004

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

악기 브랜드, 모델 엔티티 구현
2 participants
@tinon1004 @Wo-ogie