행정구역 목록 조회 API 구현 #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wo-ogie
requested changes
Feb 25, 2024
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Entity | ||
| @Table(name = "adminitrative_area_sido") | ||
| public class Sido extends TimeTrackedBaseEntity{ |
There was a problem hiding this comment.
Suggested change
| public class Sido extends TimeTrackedBaseEntity{ | |
| public class AdministrativeAreaSido extends TimeTrackedBaseEntity{ |
좀 더 길어지긴 하겠지만, 구체적인 이름을 사용하는 편이 좋아보입니다.
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Entity | ||
| @Table(name = "adminitrative_area_sido") |
Comment on lines
24
to
26
| @Id | ||
| @Column(nullable = false, updatable = false) | ||
| private Long id; |
There was a problem hiding this comment.
Suggested change
| @Id | |
| @Column(nullable = false, updatable = false) | |
| private Long id; | |
| @Id | |
| @GeneratedValue(strategy = GenerationType.IDENTITY) | |
| @Column(name="administrative_area_sido_id", nullable = false, updatable = false) | |
| private Long id; |
- PK 생성 전략은 반드시
IDENTITY로 설정해주세요. - PK 이름은 ERD대로 설정해주세요.
Comment on lines
28
to
30
| @Enumerated(EnumType.STRING) | ||
| @Column(nullable = false) | ||
| private SidoList name; |
There was a problem hiding this comment.
Suggested change
| @Enumerated(EnumType.STRING) | |
| @Column(nullable = false) | |
| private SidoList name; | |
| @Column(nullable = false) | |
| private String name; |
항목이 많지 않고, 수정될 일이 많지 않을 것으로 보여 enum value를 사용하는 것도 좋아보입니다.
다만, 시/군/구와 읍/면/동의 경우 항목이 많고 수정 소요를 고려하여 DB에서 값을 관리해야 할 것 같습니다. 그래서 시/도 역시 마찬가지로 단순 String으로 정의하고, DB에서 값을 관리하면 어떨까요?
There was a problem hiding this comment.
Commit이 "sido 엔티티 작성 및 api 구현"이므로 Emd class는 commit에 포함시키지 않는 것이 적절해 보입니다. 다음부터는 commit에 관련한 파일만 반영하도록 신경써주세요~ 🙂
Wo-ogie
force-pushed
the
feature/#38-administrative-area
branch
from
e1f6337 to
9aa17a3
Compare
|
담당 작업자의 git 운영 미숙으로 PR을 닫고 commit 내역을 초기화한다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
🏃 Task
📄 Reference