Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

내 프로필 사진 변경 API 구현 #86

Merged
merged 15 commits into from
Mar 26, 2024
Merged

내 프로필 사진 변경 API 구현 #86

merged 15 commits into from
Mar 26, 2024

Conversation

tinon1004
Copy link
Contributor

@tinon1004 tinon1004 commented Mar 18, 2024 •
edited
Loading

🔥 Related Issue

🏃‍ Task

  • AmazonS3Service: 파일 단건 삭제 기능 구현
  • 내 프로필 사진 변경 API 구현

📄 Reference

  • None

@tinon1004 tinon1004 added the enhancement New feature or request label Mar 18, 2024
@tinon1004 tinon1004 self-assigned this Mar 18, 2024
@Wo-ogie Wo-ogie closed this Mar 19, 2024
@Wo-ogie Wo-ogie reopened this Mar 19, 2024
@Wo-ogie Wo-ogie marked this pull request as draft March 19, 2024 15:03
@Wo-ogie Wo-ogie self-requested a review March 19, 2024 15:04
@tinon1004 tinon1004 marked this pull request as ready for review March 21, 2024 09:38
Wo-ogie
Wo-ogie requested changes Mar 21, 2024
View reviewed changes
src/main/java/com/ajou/hertz/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/dto/request/UpdateProfileImageUrlRequest.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/service/UserCommandService.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/common/file/dto/FileDto.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/entity/User.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/entity/UserProfileImage.java Outdated Show resolved Hide resolved
src/main/java/com/ajou/hertz/domain/user/service/UserCommandService.java Outdated Show resolved Hide resolved
@tinon1004 tinon1004 requested a review from Wo-ogie March 23, 2024 19:43
@tinon1004 tinon1004 requested a review from Wo-ogie March 24, 2024 14:31
@tinon1004 tinon1004 force-pushed the feature/#73-edit-profile-image branch from f6c1b28 to d09adb5 Compare March 25, 2024 05:09
@tinon1004 tinon1004 requested a review from Wo-ogie March 25, 2024 05:17
@tinon1004 tinon1004 requested a review from Wo-ogie March 25, 2024 07:10
@tinon1004 tinon1004 force-pushed the feature/#73-edit-profile-image branch from 11790e0 to 1199bcb Compare March 26, 2024 05:57
@tinon1004 tinon1004 requested a review from Wo-ogie March 26, 2024 06:00
Wo-ogie
Wo-ogie requested changes Mar 26, 2024
View reviewed changes
src/test/java/com/ajou/hertz/unit/domain/user/service/UserProfileImageCommandServiceTest.java Outdated
Comment on lines 39 to 40
@Mock
private HertzProperties hertzProperties;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 안쓰지 않나요?

@tinon1004 tinon1004 requested a review from Wo-ogie March 26, 2024 06:10
@Wo-ogie Wo-ogie merged commit c81bde4 into main Mar 26, 2024
1 check passed
@Wo-ogie Wo-ogie deleted the feature/#73-edit-profile-image branch March 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wo-ogie Wo-ogie Wo-ogie approved these changes

Assignees

@tinon1004 tinon1004

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

내 프로필 사진 변경 API 구현
2 participants
@tinon1004 @Wo-ogie