feat: withdrawals API docs, enhanced tests, notifications POST /:id/read - #1124
Merged
Akanimoh12 merged 1 commit intoJul 26, 2026
Conversation
- Akanimoh12#945: Add OpenAPI docs for withdrawals and balances endpoints - Akanimoh12#944: Add edge-case tests for withdrawals module (pagination, empty state, zero balance) - Akanimoh12#958: Notifications module skeleton already complete (service, controller, routes, schema, types, tests) - Akanimoh12#960: Add POST /notifications/:id/read route as alias for PATCH Closes Akanimoh12#944, Akanimoh12#945, Akanimoh12#958, Akanimoh12#960
Lekan101
force-pushed
the
feat/withdrawals-notifications-944-945-958-960
branch
from
July 26, 2026 13:02
6b19b9f to
b4b3576
Compare
Akanimoh12
merged commit Jul 26, 2026
56ab756
into
Akanimoh12:test-implement-drips
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements 4 backend issues against the
test-implement-dripsbranch:#945 — Withdrawals API docs
withdrawals.routes.tsWithdrawalstag to the shared OpenAPI document#944 — Withdrawals module tests
#958 — Notifications module skeleton
#960 — POST /notifications/:id/read
POST /:id/readroute as an alias for the existingPATCH /:id/readendpointVerification
npm run lintpasses clean (0 errors, only pre-existing warnings)npm run typecheck— pre-existing errors only (missing@stellar/stellar-sdktypes, socket.io types)Closes
Closes #944, Closes #945, Closes #958, Closes #960