Skip to content

feat: withdrawals API docs, enhanced tests, notifications POST /:id/read - #1124

Merged
Akanimoh12 merged 1 commit into
Akanimoh12:test-implement-dripsfrom
Lekan101:feat/withdrawals-notifications-944-945-958-960
Jul 26, 2026
Merged

feat: withdrawals API docs, enhanced tests, notifications POST /:id/read#1124
Akanimoh12 merged 1 commit into
Akanimoh12:test-implement-dripsfrom
Lekan101:feat/withdrawals-notifications-944-945-958-960

Conversation

@Lekan101

Copy link
Copy Markdown
Contributor

Summary

Implements 4 backend issues against the test-implement-drips branch:

#945 — Withdrawals API docs

  • Added full OpenAPI documentation for all withdrawals and balances endpoints in withdrawals.routes.ts
  • Added Withdrawals tag to the shared OpenAPI document
  • Covers: GET /withdrawals/me, POST /withdrawals/prepare, POST /withdrawals/submit, GET /balances/me

#944 — Withdrawals module tests

  • Added edge-case tests: empty withdrawal history, custom pagination params, null serialization, zero balance, 401 on unauthenticated access, empty body validation, insufficient balance on prepare

#958 — Notifications module skeleton

  • Verified the notifications module skeleton is complete (service, controller, routes, schema, types, tests)

#960 — POST /notifications/:id/read

  • Added POST /:id/read route as an alias for the existing PATCH /:id/read endpoint
  • Added OpenAPI docs for the POST variant
  • Added comprehensive tests for the POST route (success, 404, 401, cross-user)

Verification

  • npm run lint passes clean (0 errors, only pre-existing warnings)
  • npm run typecheck — pre-existing errors only (missing @stellar/stellar-sdk types, socket.io types)

Closes

Closes #944, Closes #945, Closes #958, Closes #960

- Akanimoh12#945: Add OpenAPI docs for withdrawals and balances endpoints
- Akanimoh12#944: Add edge-case tests for withdrawals module (pagination, empty state, zero balance)
- Akanimoh12#958: Notifications module skeleton already complete (service, controller, routes, schema, types, tests)
- Akanimoh12#960: Add POST /notifications/:id/read route as alias for PATCH

Closes Akanimoh12#944, Akanimoh12#945, Akanimoh12#958, Akanimoh12#960
@Lekan101
Lekan101 force-pushed the feat/withdrawals-notifications-944-945-958-960 branch from 6b19b9f to b4b3576 Compare July 26, 2026 13:02
@Akanimoh12
Akanimoh12 merged commit 56ab756 into Akanimoh12:test-implement-drips Jul 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants