feat: implement solutions for CT-14 and CT-19 - #177
Merged
Qoder-Voidd merged 1 commit intoJul 28, 2026
Merged
Conversation
CT-14 (Akazajan#93): Add role-based authorization checks for admin-only functions with comprehensive tests CT-19 (Akazajan#98): Add multisig admin ownership transfer via proposal with TransferAdmin action
|
@Penielka Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements solutions for two issues assigned to Penielka:
CT-14 (#93): Add role-based authorization checks for admin-only functions
access_control_role_tests.rswith comprehensive real tests covering:CT-19 (#98): Add support for ownership transfer between administrators
ProposalAction::TransferAdmin(new_admin)handling inexecute_proposalDataKey::Adminand swaps rolestest_multisig_admin_transfer_via_proposal: Full flow success (verifies roles, multisig config, old admin loses privileges)test_multisig_transfer_admin_to_self_fails: Self-transfer blocked with DuplicateAdmintest_multisig_prevents_direct_admin_transfer: Direct transfer blocked in multisig modeAdditional Fixes
manage_hub/src/errors.rs(extra variants after closing brace)SubscriptionInvalid = 57error variant (referenced by subscription.rs but was missing from enum)closes #91
closes #92
closes #98
closes #93