-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update directory_tree.py: Fixed double clicking #1512
Conversation
Fixed double click to work properly
Thanks for working on this! Your solution is nicer than calculating milliseconds. I noticed two differences to how this behaved before. Can you look into whether we can keep the old behavior?
a-2024-06-21_13.05.56.mp4
b-2024-06-21_13.07.16.mp4These probably have something to do with |
single click now expands folder without needing to click on arrow
It's working as you described now, was as simple as adding |
I pushed a couple small changes. You will need to run |
porcupine/plugins/directory_tree.py
Outdated
|
||
little_arrow_clicked = self.identify_element(event.x, event.y) == "Treeitem.indicator" | ||
|
||
if little_arrow_clicked or not item.startswith("file"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need little_arrow_clicked
anymore, because directories open regardless of where you click, and files don't have the arrow.
removed little_arrow_clicked and changed if statement to if item.startswith(("dir", "project")):
Fixed double click to work properly