Fix behavior of null in IN and NOT IN operators with empty sets #2310
+46
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where
SELECT null IN ()andSELECT null NOT IN ()were returning NULL instead of the expected false and true values respectively.Changes Made
Fixed Expression Compiler (
src/50expression.js):skipNullCheckflag to the expression compilation logicIN ()always returnsfalse(nothing is in an empty set),NOT IN ()always returnstrue(everything is not in an empty set)Added Test Case (
test/test1529.js):null IN ()returnsfalsenull NOT IN ()returnstrueTesting
The fix is minimal and surgical, only affecting the specific case of empty arrays in IN/NOT IN operators with null operands, while preserving all existing behavior for non-empty sets and non-null operands.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.