Skip to content

Add parser support for ON DELETE and ON UPDATE CASCADE in REFERENCES #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Add parser support for ON DELETE and ON UPDATE CASCADE in REFERENCES #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa90dee
Initial plan
Copilot Dec 2, 2025
eb13ca1
Add support for ON DELETE and ON UPDATE CASCADE in REFERENCES
Copilot Dec 2, 2025
8ee4676
Add comprehensive tests for FOREIGN KEY edge cases and combinations
Copilot Dec 2, 2025
cff7bb6
Changes before error encountered
Copilot Dec 3, 2025
7de8102
Revert unrelated test293.js changes and add behavior verification to …
Copilot Dec 4, 2025
d5d8571
Add behavior verification to all CASCADE tests with data operations
Copilot Dec 4, 2025
e734489
mergefix
mathiasrw Dec 7, 2025
85c2df4
Refactor tests to use deepEqual, multiline SQL, and comprehensive dat…
Copilot Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 34 additions & 13 deletions src/alasqlparser.jison
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ NOT\s+ILIKE return 'NOT_LIKE'

'CALL' return 'CALL'
'CASE' return 'CASE'
'CASCADE' return 'CASCADE'
'CAST' return 'CAST'
'CHECK' return 'CHECK'
'CLASS' return 'CLASS'
Expand Down Expand Up @@ -217,6 +218,7 @@ DATABASE(S)? return 'DATABASE'
'RENAME' return 'RENAME'
'REPEAT' return 'REPEAT'
'REPLACE' return 'REPLACE'
'RESTRICT' return 'RESTRICT'
'REQUIRE' return 'REQUIRE'
'RESTORE' return 'RESTORE'
'RETURN' return 'RETURN'
Expand Down Expand Up @@ -2029,29 +2031,48 @@ PrimaryKey

ForeignKey
: FOREIGN KEY LPAR ColsList RPAR REFERENCES Table ParColsList?
OnForeignKeyClause
{ $$ = {type: 'FOREIGN KEY', columns: $4, fktable: $7, fkcolumns: $8}; }
OnReferentialActions
{ $$ = {type: 'FOREIGN KEY', columns: $4, fktable: $7, fkcolumns: $8}; yy.extend($$, $9); }
;

ParColsList
: LPAR ColsList RPAR
{ $$ = $2; }
;

OnForeignKeyClause
OnReferentialActions
:
{ $$ = undefined; }
{$$ = {}; }
| OnDeleteClause
{$$ = {ondelete: $1}; }
| OnUpdateClause
{$$ = {onupdate: $1}; }
| OnDeleteClause OnUpdateClause
{ $$ = undefined; }
{$$ = {ondelete: $1, onupdate: $2}; }
| OnUpdateClause OnDeleteClause
{$$ = {ondelete: $2, onupdate: $1}; }
;

OnDeleteClause
: ON DELETE NO ACTION
{$$ = undefined; }
: ON DELETE ReferentialAction
{$$ = $3; }
;
OnUpdateClause
: ON UPDATE NO ACTION
{$$ = undefined; }
: ON UPDATE ReferentialAction
{$$ = $3; }
;

ReferentialAction
: CASCADE
{$$ = 'CASCADE'; }
| SET NULL
{$$ = 'SET NULL'; }
| SET DEFAULT
{$$ = 'SET DEFAULT'; }
| RESTRICT
{$$ = 'RESTRICT'; }
| NO ACTION
{$$ = 'NO ACTION'; }
;

UniqueKey
Expand Down Expand Up @@ -2166,10 +2187,10 @@ ParLiteral
ColumnConstraint
: PRIMARY KEY
{$$ = {primarykey:true};}
| FOREIGN KEY REFERENCES Table ParLiteral?
{$$ = {foreignkey:{table:$4, columnid: $5}};}
| REFERENCES Table ParLiteral?
{$$ = {foreignkey:{table:$2, columnid: $3}};}
| FOREIGN KEY REFERENCES Table ParLiteral? OnReferentialActions
{$$ = {foreignkey:{table:$4, columnid: $5}}; yy.extend($$.foreignkey, $6);}
| REFERENCES Table ParLiteral? OnReferentialActions
{$$ = {foreignkey:{table:$2, columnid: $3}}; yy.extend($$.foreignkey, $4);}
| IDENTITY LPAR NumValue COMMA NumValue RPAR
{ $$ = {identity: {value:$3,step:$5}} }
| IDENTITY
Expand Down
Loading
Loading