Rearrange page search #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
from
9962864 to
82f1f86
Compare
tvdeyen
reviewed
Oct 10, 2024
tvdeyen
reviewed
Oct 10, 2024
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
3 times, most recently
from
9a1a408 to
fdbc9d5
Compare
tvdeyen
reviewed
Oct 11, 2024
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
3 times, most recently
from
905f303 to
57d3108
Compare
tvdeyen
reviewed
Oct 14, 2024
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
2 times, most recently
from
7146218 to
35a9c75
Compare
tvdeyen
reviewed
Oct 14, 2024
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
from
35a9c75 to
9c8563f
Compare
Previously the page and the ingredients (and in previous versions also essences) were stored as separate PgSearch::Document entries. On search these document were combined to a single document to make it usable in the search itself. These mechanic made it pretty difficult to extend the search with other models. In newer versions of Alchemy the page is only available after a new page version is released and these mechanic is used to create a single PgSearch::Document with the content of the page and all supported ingredients. This change makes the whole search and the index creation less complex. The Alchemy module now has searchable_ingredients attribute which makes it easier to change the indexing from the outside. Furthermore a few extensions are now in a Search namespace, because they are not related to the PgSearch gem.
Add headline to the list of supported ingredients. It contains valuable information and should be in the search index.
sascha-karnatz
force-pushed
the
rearrange-page-search
branch
from
9c8563f to
8a19294
Compare
tvdeyen
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the page and the ingredients (and in previous versions also essences) were stored as separate PgSearch::Document entries. On search these document were combined to a single document to make it usable in the search itself. These mechanic made it pretty difficult to extend the search with other models. In newer versions of Alchemy the page is only available after a new page version is released and these mechanic is used to create a single PgSearch::Document with the content of the page and all supported ingredients. This change makes the whole search and the index creation less complex.