Add search page module and remove controller extension #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Oct 28, 2024
sascha-karnatz
force-pushed
the
search-page-module
branch
from
b73f2cd to
98f3046
Compare
tvdeyen
requested changes
Oct 28, 2024
tvdeyen
reviewed
Oct 28, 2024
sascha-karnatz
force-pushed
the
search-page-module
branch
from
98f3046 to
4b06767
Compare
The controller methods were available on every page in Alchemy and was listening to the query param. This approach is not really extendable, if you need multiple parameter to process the search result. The main logic was moved into a SearchPage module which has nearly the same structure as before, but is now way more flexible, because it is only used in this particular page layout. It also allows the application to extend the search and the view without monkey patching the gem. The only downside is, that it isn't possible anymore to add a search string the searchresults - element to test the search in the admin interface.
The helper method was only a short cut for the results partial, but it was using the global search_results variable from the previous controller_methods extension. With the SearchPage module it isn't necessary anymore to have a global variable.
sascha-karnatz
force-pushed
the
search-page-module
branch
from
4b06767 to
e5dfcdb
Compare
tvdeyen
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller methods were available on every page in Alchemy and was listening to the query param. This approach is not really extendable, if you need multiple parameter to process the search result. The main logic was moved into a SearchPage module which has nearly the same structure as before, but is now way more flexible, because it is only used in this particular page layout. It also allows the application to extend the search and the view without monkey patching the gem. The only downside is, that it isn't possible anymore to add a search string the searchresults - element to test the search in the admin interface.