colorized & arg for hyfetch #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the colors.py module may need to be move to src/tools - now using delicate qwqfetch can show color correct, but failed when combined with hyfetch's colors. - more robust distro detector
- Fix procedure to produce colorized text with asc in (1 - Hardcoded bold text
- keep indent at zero when get_result() - color blocks implemented using two for-loop
- remove debug output from colors.py note that qwqfetch doesn't have debug opt by now
- minor changes to get_color_blocks()
|
Thanks for the pr! This repo is temporarily abandoned anyway, needing mass code refactor, but I've got a lot of things to do now.In fact, the author of hyfetch is not very optimistic about these codes. I also did not consider many things when writing these codes, such as dynamically calling the C language library. I haven't looked at your code carefully (and actually I kind of forget what shit I wrote). But I can spare some time to work on this project too if you want to contribute. Maybe within this weekend. |
reuse get_result, then concat in get_ascres see line 70
ignore egg-info
chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just set an
ascarg in get_result() for pass asciiart produced by hyfetch.As I have no idea about how python module structured, newly added
colors.pyfile may need to move to tools/ folder.Mostly use f-strings to speed up string production, however
get_color_blocksperformance is poor due to use of for-loop. More pythonic candy should apply for optimize.