Closed
Conversation
Contributor
Author
|
As discussed in #251, this will be kept on hold until the CLI release |
escritorio-gustavo
added
Next Major Release
CLI
Contributor
Author
|
Obsolete as of #304 |
amireh
added a commit
to amireh/ts-rs
that referenced
this pull request
Dec 23, 2025
this patch introduces a new feature - "export-bindings" - to grant
downstream more control over when the bindings are generated.
With the feature disabled in Cargo.toml, the bindings are not exported
automatically on every test run. The user can choose when to export by
explicitly enabling the feature with the --features cargo test flag.
For example, in my Cargo.toml:
```toml
[dependencies]
ts-rs = { version = "11", default-features = false, features = [
"serde-compat",
"no-serde-warnings",
] }
```
And at the time I need to export the bindings:
cargo test --features export-bindings -- 'export_bindings_'
This is somewhat related to Aleph-Alpha#62 and Aleph-Alpha#253.
amireh
added a commit
to amireh/ts-rs
that referenced
this pull request
Dec 23, 2025
this patch introduces a new feature - "export-bindings" - to grant
downstream more control over when the bindings are generated.
With the feature disabled in Cargo.toml, the bindings are not exported
automatically on every test run. The user can choose when to export by
explicitly enabling the feature with the --features cargo test flag.
For example, in my Cargo.toml:
```toml
[dependencies]
ts-rs = { version = "11", default-features = false, features = [
"serde-compat",
"no-serde-warnings",
] }
```
And at the time I need to export the bindings:
cargo test --features export-bindings -- 'export_bindings_'
This is somewhat related to Aleph-Alpha#62 and Aleph-Alpha#253.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ts-rs exports its TypeScript bindings in every test run. This seems to really upset some people, and with good reasons:
So this PR proposes a way to change that by adding
#[ignore]to all ts-rs tests. This enables users to:cargo testcargo test export_bindings_ -- --ignoredcargo test -- --ignored(though this does have the downside of running the user's own ignored tests)Fixes #62