refactor: fix clippy lints#455
Merged
gustavo-shigueo merged 1 commit intoAleph-Alpha:mainfrom Nov 5, 2025
Merged
Conversation
gustavo-shigueo
requested changes
Nov 5, 2025
Collaborator
gustavo-shigueo
left a comment
There was a problem hiding this comment.
Hi @sandr01d, thanks for the PR! There is only one test I'd like you to revert as the intention is to make sure export_to works with any expression, not just string literals
Collaborator
This had me really concerned that the MSRV check was giving invalid passes until I checked that both uses are in the tests lol |
2d5b065 to
a98991c
Compare
Contributor
Author
|
Thanks for the quick review, everything should be addressed @gustavo-shigueo |
gustavo-shigueo
approved these changes
Nov 5, 2025
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes clippy lints without introducing any actual changes. The lint regarding usage of
parseinstead offrom_str_radixshows up in projects usingts-rsas a dependency due to it being used in the derive macro forTS. This trips over the CI in the project I'm usingts-rswith.Changes
Implements the changes suggested by clippy without introducing any changes in behavior. I added an
#[allow(clippy::enum_variant_names)]for theOptionalenum because changing the names of the variants would not make any sense IMO.There are two lints left regarding
std::path::absoluteonly being available in Rust 1.79.0 and the project using 1.78.0. Guess the best way to resolve that is to update the Rust version, so I left out those ones.Checklist