Remove "effects" macro #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced it isn't g++ that's broken here |
|
It's practically a philosophical point. If the compiler's broken, maybe just merge this and then revert it when the compiler gets unbroken. At the moment you have a major release of the most popular Linux compiler not working with the codebase. |
|
A bleeding edge build from git, actually. I'm struggling to build it here in order to test the change |
|
Ah, well I hadn't opened AlephOne for a while so was assuming the 14.2 release in general was doing that (August). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking builds on current g++ (see #530 )