Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-dressca-frontend: bump vite from 5.4.6 to 5.4.8 in /samples/Dressca/dressca-frontend #1786

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2024

Bumps vite from 5.4.6 to 5.4.8.

Changelog

Sourced from vite's changelog.

5.4.8 (2024-09-25)

5.4.7 (2024-09-20)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file npm npmパッケージの更新 target: Dressca サンプルアプリケーションDresscaに関係がある labels Sep 25, 2024
@KentaHizume
Copy link
Contributor

viteがrollupの不具合修正待ちの状態。

ただ、問題となっている脆弱性はバンドルした結果がcjs形式のときしか影響がないらしいので、Marisには影響がなかった。(デフォルト値でバンドルするとesmになるため)

https://ja.vitejs.dev/config/build-options#build-target
最終的なバンドルのブラウザー互換性のターゲット。デフォルトは Vite の特別な値 'modules' で、これはネイティブ ES モジュールネイティブ ESM の動的インポートimport.metaをサポートするブラウザーを対象にします。Vite は 'modules' を ['es2020', 'edge88', 'firefox78', 'chrome87', 'safari14'] へ置き換えます。

note that the CVE only affects non-ESM outputs
GHSA-gcx4-mw62-g8wm

A DOM Clobbering vulnerability in rollup bundled scripts was identified, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/samples/Dressca/dressca-frontend/vite-5.4.8 branch 5 times, most recently from 85f768d to c0a3928 Compare September 30, 2024 00:26
@KentaHizume
Copy link
Contributor

rollupの修正およびリリースが完了、ViteのPRは下記。

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/samples/Dressca/dressca-frontend/vite-5.4.8 branch from c0a3928 to f5512e8 Compare September 30, 2024 07:10
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.6 to 5.4.8.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.8/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.8/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/samples/Dressca/dressca-frontend/vite-5.4.8 branch from f5512e8 to ed5fe83 Compare October 2, 2024 01:58
@KentaHizume KentaHizume added this to the v0.10 milestone Oct 3, 2024
@KentaHizume KentaHizume merged commit 6a744c3 into main Oct 3, 2024
2 checks passed
@KentaHizume KentaHizume deleted the dependabot/npm_and_yarn/samples/Dressca/dressca-frontend/vite-5.4.8 branch October 3, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file npm npmパッケージの更新 target: Dressca サンプルアプリケーションDresscaに関係がある
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant