Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLコメントの文体を統一する #2239

Merged
merged 4 commits into from
Jan 8, 2025
Merged

XMLコメントの文体を統一する #2239

merged 4 commits into from
Jan 8, 2025

Conversation

fkoyama
Copy link
Contributor

@fkoyama fkoyama commented Jan 7, 2025

この Pull request で実施したこと

サンプルアプリのXMLコメントの文体を修正しました。

この Pull request では実施していないこと

なし

Issues や Discussions 、関連する Web サイトなどへのリンク

なし

@fkoyama fkoyama added target: Dressca サンプルアプリケーションDresscaに関係がある target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある target: Azure AD B2C Auth Azure AD B2C認証の要件別サンプルに関係がある 内部の改善 機能更新やドキュメント更新ではない改善 labels Jan 7, 2025
@fkoyama fkoyama added this to the v1.0.0 milestone Jan 7, 2025
@fkoyama fkoyama self-assigned this Jan 7, 2025
@fkoyama fkoyama linked an issue Jan 7, 2025 that may be closed by this pull request
XMLコメントの文体を統一する #2019
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Test Result 📝

Test was a success.
Completed in 21195ms with 249 passed, 0 failed and 0 skipped.

Coverage 📐

Summary
Generated on: 01/08/2025 - 04:50:35
Coverage date: 01/08/2025 - 04:50:26 - 01/08/2025 - 04:50:31
Parser: MultiReport (6x Cobertura)
Assemblies: 8
Classes: 121
Files: 119
Line coverage: 36.8% (1544 of 4190)
Covered lines: 1544
Uncovered lines: 2646
Coverable lines: 4190
Total lines: 9345
Branch coverage: 48.5% (205 of 422)
Covered branches: 205
Total branches: 422
Method coverage: Feature is only available for sponsors
Tag: 48_12664270339
Dressca.ApplicationCore - 89.9%
Name Line Branch
Dressca.ApplicationCore 89.9% 79.5%
Dressca.ApplicationCore.Accounting.Account 100% 100%
Dressca.ApplicationCore.Accounting.AccountItem 100%
Dressca.ApplicationCore.ApplicationCoreServicesExtensions 100%
Dressca.ApplicationCore.ApplicationService.AssetApplicationService 100% 70%
Dressca.ApplicationCore.ApplicationService.CatalogApplicationService 100% 83.3%
Dressca.ApplicationCore.ApplicationService.CatalogBrandNotExistingInReposit
oryException		 100%
Dressca.ApplicationCore.ApplicationService.CatalogCategoryNotExistingInRepo
sitoryException		 100%
Dressca.ApplicationCore.ApplicationService.CatalogItemNotExistingInReposito
ryException		 100%
Dressca.ApplicationCore.ApplicationService.OrderApplicationService 100% 75%
Dressca.ApplicationCore.ApplicationService.ShoppingApplicationService 100% 78.5%
Dressca.ApplicationCore.ApplicationService.TransactionScopeManager 100% 100%
Dressca.ApplicationCore.Assets.Asset 88.8% 100%
Dressca.ApplicationCore.Assets.AssetNotFoundException 100%
Dressca.ApplicationCore.Assets.AssetTypes 100% 100%
Dressca.ApplicationCore.Authorization.NotConnectedUserStore 0%
Dressca.ApplicationCore.Authorization.PermissionDeniedException 100%
Dressca.ApplicationCore.Authorization.Roles 100%
Dressca.ApplicationCore.Baskets.Basket 100% 100%
Dressca.ApplicationCore.Baskets.BasketItem 84.2% 75%
Dressca.ApplicationCore.Baskets.CatalogItemNotExistingInBasketException 100%
Dressca.ApplicationCore.Catalog.CatalogBrand 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogCategory 84.6% 100%
Dressca.ApplicationCore.Catalog.CatalogDomainService 100% 60%
Dressca.ApplicationCore.Catalog.CatalogItem 72.1% 66.6%
Dressca.ApplicationCore.Catalog.CatalogItemAsset 85.7% 75%
Dressca.ApplicationCore.Events 100%
Dressca.ApplicationCore.Ordering.Address 61.1% 100%
Dressca.ApplicationCore.Ordering.CatalogItemOrdered 90% 100%
Dressca.ApplicationCore.Ordering.EmptyBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.NullBasketOnCheckoutException 100%
Dressca.ApplicationCore.Ordering.Order 88% 87.5%
Dressca.ApplicationCore.Ordering.OrderFactory 0%
Dressca.ApplicationCore.Ordering.OrderItem 88.2% 25%
Dressca.ApplicationCore.Ordering.OrderItemAsset 85.7% 75%
Dressca.ApplicationCore.Ordering.OrderNotFoundException 100%
Dressca.ApplicationCore.Ordering.ShipTo 58.3% 50%
Dressca.ApplicationCore.Resources.LogMessages 92.5% 100%
Dressca.ApplicationCore.Resources.Messages 88.8% 100%
Dressca.EfInfrastructure - 13.9%
Name Line Branch
Dressca.EfInfrastructure 13.9% 9%
Dressca.EfInfrastructure.Configurations.Assets.AssetConfiguration 100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketConfiguration 100%
Dressca.EfInfrastructure.Configurations.Baskets.BasketItemConfiguration 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogBrandConfiguration 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogCategoryConfiguratio
n		 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemAssetConfigurati
on		 100%
Dressca.EfInfrastructure.Configurations.Catalog.CatalogItemConfiguration 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderConfiguration 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemAssetConfiguratio
n		 100%
Dressca.EfInfrastructure.Configurations.Ordering.OrderItemConfiguration 100%
Dressca.EfInfrastructure.DresscaDbContext 83.7% 50%
Dressca.EfInfrastructure.EfAssetRepository 0% 0%
Dressca.EfInfrastructure.EfBasketRepository 0% 0%
Dressca.EfInfrastructure.EfCatalogBrandRepository 0% 0%
Dressca.EfInfrastructure.EfCatalogCategoryRepository 0% 0%
Dressca.EfInfrastructure.EfCatalogRepository 0% 0%
Dressca.EfInfrastructure.EfInfrastructureServicesExtension 81.8% 50%
Dressca.EfInfrastructure.EfOrderRepository 0% 0%
Dressca.EfInfrastructure.Events 0%
Dressca.EfInfrastructure.HealthChecksBuilderExtensions 60%
Dressca.EfInfrastructure.Migrations.DresscaDbContextModelSnapshot 0%
Dressca.EfInfrastructure.Migrations.InitialCreate 0%
Dressca.EfInfrastructure.Resources.Messages 0% 0%
Dressca.Store.Assets.StaticFiles - 9.4%
Name Line Branch
Dressca.Store.Assets.StaticFiles 9.4% 0%
Dressca.Store.Assets.StaticFiles.Events 0%
Dressca.Store.Assets.StaticFiles.Resources.LogMessages 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStore 0% 0%
Dressca.Store.Assets.StaticFiles.StaticFileAssetStoreServicesExtension 100%
Dressca.SystemCommon - 77.4%
Name Line Branch
Dressca.SystemCommon 77.4% 84.6%
Dressca.SystemCommon.BusinessError 100% 83.3%
Dressca.SystemCommon.BusinessErrorCollection 88.8% 100%
Dressca.SystemCommon.BusinessException 93.7% 100%
Dressca.SystemCommon.PagedList`1 0% 0%
Dressca.SystemCommon.Resources.Messages 55.5% 100%
Dressca.SystemCommon.Text.Json.DefaultJsonSerializerOptions 100%
System.ObjectExtensions 80% 50%
System.StringExtentions 100% 100%
Dressca.Web - 33%
Name Line Branch
Dressca.Web 33% 16.6%
__OptionValidationGeneratedAttributes 0% 0%
__OptionValidationStaticInstances 0%
Dressca.Web.Authorization.DummyAuthenticationHandler 100%
Dressca.Web.Authorization.StatusCodeMapAuthorizationMiddlewareResultHandler 0% 0%
Dressca.Web.Configuration.CookieSettingsValidator 0% 0%
Dressca.Web.Configuration.CookieSettings 25% 0%
Dressca.Web.Configuration.ValidateWebServerOptions 0% 0%
Dressca.Web.Configuration.WebServerOptions 100%
Dressca.Web.Controllers.ActionNameHelper 0% 0%
Dressca.Web.Controllers.ErrorController 8.3% 0%
Dressca.Web.Events 100%
Dressca.Web.HealthChecks.HealthCheckDescriptionProvider 7.8% 25%
Dressca.Web.Resources.LogMessages 55.5% 100%
Dressca.Web.Resources.Messages 54.1% 100%
Dressca.Web.Runtime.BusinessExceptionDevelopmentFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilter 100% 50%
Dressca.Web.Runtime.BusinessExceptionFilterBase 100% 83.3%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionDevelopmentFilter 100% 50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilter 100% 50%
Dressca.Web.Runtime.DbUpdateConcurrencyExceptionFilterBase 100% 75%
Dressca.Web.Admin - 24.8%
Name Line Branch
Dressca.Web.Admin 24.8% 9%
Dressca.Web.Admin.Assets.AssetExtensions 0% 0%
Dressca.Web.Admin.Authorization.UserStore 0% 0%
Dressca.Web.Admin.Controllers.ApiModel.FindCatalogItemsQuery 0%
Dressca.Web.Admin.Controllers.AssetsController 0% 0%
Dressca.Web.Admin.Controllers.CatalogBrandsController 0% 0%
Dressca.Web.Admin.Controllers.CatalogCategoriesController 0% 0%
Dressca.Web.Admin.Controllers.CatalogItemsController 0% 0%
Dressca.Web.Admin.Controllers.UsersController 0% 0%
Dressca.Web.Admin.Events 0%
Dressca.Web.Admin.Mapper.CatalogBrandMapper 0% 0%
Dressca.Web.Admin.Mapper.CatalogCategoryMapper 0% 0%
Dressca.Web.Admin.Mapper.CatalogItemMapper 0% 0%
Dressca.Web.Admin.Mapper.DtoMapperServicesExtension 100%
Dressca.Web.Admin.Resources.LogMessages 0% 0%
Dressca.Web.Admin.Resources.Messages 0% 0%
Program 79.2% 60%
Dressca.Web.Admin.Dto - 0%
Name Line Branch
Dressca.Web.Admin.Dto 0% ****
Dressca.Web.Admin.Dto.CatalogBrands.GetCatalogBrandsResponse 0%
Dressca.Web.Admin.Dto.CatalogCategories.GetCatalogCategoriesResponse 0%
Dressca.Web.Admin.Dto.CatalogItems.GetCatalogItemResponse 0%
Dressca.Web.Admin.Dto.CatalogItems.PostCatalogItemRequest 0%
Dressca.Web.Admin.Dto.CatalogItems.PutCatalogItemRequest 0%
Dressca.Web.Admin.Dto.Users.GetLoginUserResponse 0%
Maris.Logging.Testing - 94.2%
Name Line Branch
Maris.Logging.Testing 94.2% 100%
Maris.Logging.Testing.Xunit.TestLoggerManager 100% 100%
Maris.Logging.Testing.Xunit.XunitLogger 76.4% 100%
Maris.Logging.Testing.Xunit.XunitLoggerProvider 100% 100%
Microsoft.Extensions.DependencyInjection.TestLoggerServiceCollectionExtensi
ons		 100%
Microsoft.Extensions.Logging.FakeLoggingBuilderExtensions 100%
Microsoft.Extensions.Logging.XunitLoggingBuilderExtensions 100%

@tsuna-can-se tsuna-can-se merged commit 0407286 into main Jan 8, 2025
12 checks passed
@tsuna-can-se tsuna-can-se deleted the feature/XMLコメントの文体を統一する branch January 8, 2025 04:59
KentaHizume added a commit that referenced this pull request Jan 8, 2025
@KentaHizume
下記の変更時にOpenAPI仕様書への変更がコミットされていないため、再生成のうえコミットします。
835a3ba 
- #2239
@KentaHizume KentaHizume mentioned this pull request Jan 8, 2025
Merged
fkoyama pushed a commit that referenced this pull request Jan 9, 2025
@KentaHizume
XMLコメントの変更をOpenAPI仕様書・クライアントコードに反映する (#2249)
a4d0e88 
* 下記の変更時にOpenAPI仕様書への変更がコミットされていないため、再生成のうえコミットします。
- #2239

* フロントエンド側のコードを再生成

* OpenAPI仕様書を再生成

* クライアントコードを再生成
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuna-can-se tsuna-can-se tsuna-can-se approved these changes

Assignees

@fkoyama fkoyama

Labels
target: Azure AD B2C Auth Azure AD B2C認証の要件別サンプルに関係がある target: ConsoleAppWithDI コンソールアプリケーションの要件別サンプルに関係がある target: Dressca サンプルアプリケーションDresscaに関係がある 内部の改善 機能更新やドキュメント更新ではない改善
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

XMLコメントの文体を統一する
2 participants
@fkoyama @tsuna-can-se