New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs in update of offset/lock: missing function ref, bad scoping … #5

Open

hairylime wants to merge 3 commits into AlexandreBonaventure:master from hairylime:master

hairylime commented Dec 19, 2018

…on watch and mount hooks

Tried to use the update of offset (on a screen resize event) and got a series of errors from the module:

missing updateWatcher method on $scrollMonitor
in vue, you can't use arrow functions on watchers if you need 'this' to resolve to the component
beforeMount nextTick doesn't seem to work (_container never initialized), changed to mounted on ScrollContainer (since that is effectively 'mount started') and mounted/nextTick on ScrollItem ('mount finished')

Brandon Alessi and others added 3 commits

December 19, 2018 11:49


          fix bugs in update of offset/lock: missing function ref, bad scoping …

42a49df

…on watch and mount hooks


          add a prepare to generate dist from github?

4607b54

fcc51b0

add recalculate method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet