Skip to content

feat(desktop): Complete GUI Remaster (Industrial Theme) + Automated OS Installers - #289

Open
Kcguner wants to merge 2 commits into
AlexsJones:mainfrom
Kcguner:main
Open

Kcguner wants to merge 2 commits into
AlexsJones:mainfrom
Kcguner:main

Conversation

@Kcguner

@Kcguner Kcguner commented Mar 23, 2026

Copy link
Copy Markdown

Hi @AlexsJones, amazing core engine! I've been working on elevating the desktop experience to match the quality of the underlying hardware logic.

🚀 The Upgrades

This PR fundamentally remasters the Tauri Desktop GUI into a professional, hardware-focused "Industrial & Precise" framework, whilst bringing robust cross-platform CI/CD pipelines so users can directly download the desktop tool on Windows, macOS, and Linux without touching the terminal.

🎨 1. UI/UX Remaster

  • Industrial Structural Design: Moved away from standard web-looking components into a dense, data-heavy dashboard aesthetic using Zinc/Amber color scales.
  • Typography: Integrated Chivo for crisp, geometric headers and JetBrains Mono for precise hardware metric tracking.
  • Deep Refactoring: Fixed all blank screen/freezing bugs by cleanly separating React state management from the Tauri backend events.

⚙️ 2. Automated OS Installers

  • Rewrote the release-desktop.yml CI/CD pipeline.
  • It now automatically generates and packages .msi (Windows), .dmg (macOS), and .deb (Linux) installers on every tag push.
  • Bypassed the dependency issues with the previous Cargo Workspaces target directories.

The README has also been updated to reflect the new Desktop App prominence and download instructions. Looking forward to your thoughts!

@AlexsJones

Copy link
Copy Markdown
Owner

thanks, going to take a look over the next few days

@three-foxes-in-a-trenchcoat

Copy link
Copy Markdown
Collaborator

Wow, Kaan — this is a massive PR. 100+ files, complete GUI overhaul + multi-OS installer pipeline. Impressive scope.

Verdict: Needs Work

Pros:

  • The multi-OS CI/CD pipeline is well-designed — matrix build for macOS/Windows/Linux with proper artifact collection
  • Industrial/Zinc/Amber theme is cohesive
  • Clean separation of React state from Tauri backend events (fixes the blank screen bug)
  • New frontend structure with Tailwind + Vite is modern and maintainable

Issues to address:

  1. AGENTS.md was deleted. This was the detailed project documentation for AI agents. It covered architecture, data flow, conventions, testing strategy, and common tasks. Please restore it or move the relevant content before merge.

  2. This PR bundles too many changes. GUI redesign, CI/CD pipeline, icon assets, .gitignore changes, Cargo.toml changes, frontend config — all in one PR. Consider splitting:

    • PR 1: CI/CD pipeline for installers (purely infra, easy to review)
    • PR 2: GUI redesign (the bulk)
    • PR 3: Supporting changes (icons, .gitignore, etc.)
  3. The frontend dependency changes (package.json, tailwind config, etc.) are spread across the diff. A separate review of the frontend code would help.

Verdict: Needs Work — restore AGENTS.md and consider splitting. The core work is solid, but the scope is too large for a single review pass.

Repository owner deleted a comment from three-foxes-in-a-trenchcoat Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work - see my comments. This is a massive PR (100+ files) combining GUI redesign with CI/CD pipeline changes. I'd strongly suggest splitting into smaller PRs. The AGENTS.md deletion is concerning and the branch targeting main instead of a feature branch makes this hard to review incrementally. Please address scope and consider a staged approach.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work. This is a massive PR (100+ files) combining a full GUI redesign with CI/CD pipeline changes. I'd strongly suggest splitting into smaller PRs. The AGENTS.md deletion is concerning and the branch targeting main instead of a feature branch makes this hard to review incrementally. Please address scope and consider a staged approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants