Conversation
b91dc29 to
b25e1d7
Compare
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
Overall: Good addition of AraCode-7B-GGUF as the first open-source Arabic-specialized coding model. The FALLBACK entry is a smart approach for GGUF-native repos without safetensors metadata. LGTM.
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
Interesting data change — replacing tiny-random test models with real embedding models. Good direction, but this PR currently has merge conflicts (DIRTY state). Please rebase on latest main to resolve. The model additions themselves look fine once conflicts are cleared.
AlexsJones
left a comment
There was a problem hiding this comment.
Thanks for adding the AraCode-7B-GGUF model — the script changes look good and the GGUF fallback approach makes sense.
However, the regenerated data/hf_models.json and llmfit-core/data/hf_models.json have lost ~1,650 auto-discovered models (every entry with "_discovered": true is gone). The diff shows 1,904 models removed vs 263 added per file — that's a major data regression.
This likely happened because the scraper was run locally without the discovery pipeline that populates those entries.
Ask: Please don't regenerate the full JSON files. Instead, just add the new rahimdzx/AraCode-7B-GGUF entry to both JSON files directly (keeping all existing models intact). The script change to scrape_hf_models.py is fine as-is.
|
Hey @Rahimdzx, please run |
Adds the first open-source Arabic-specialized code explanation and generation model to the curated TARGET_MODELS list. Since this is a GGUF-native repo (no safetensors metadata), a FALLBACK entry is also included so the scraper always produces a valid record. Model details: - Architecture: qwen2, 7.6B params - Format: GGUF, Q4_K_M quantization (~4.68 GB) - Context: 32768 tokens - Use case: coding (Arabic + English) - License: Apache-2.0 JSON entries added directly without regenerating the full files, preserving all existing auto-discovered models.
b25e1d7 to
4d3ab0e
Compare
Summary
rahimdzx/AraCode-7B-GGUFto the curatedTARGET_MODELSlist inscripts/scrape_hf_models.pyFALLBACKentry — GGUF-native repos have no safetensors metadata so the scraper returnsNone; the fallback guarantees the record is always emitteddata/hf_models.jsonandllmfit-core/data/hf_models.jsonvia the scraperModel details
rahimdzx/AraCode-7B-GGUFThis is the first open-source Arabic-specialized code explanation and generation model.
Test plan
scrape_hf_models.pyruns without errorsrahimdzx/AraCode-7B-GGUFpresent indata/hf_models.jsonwith correct fieldsllmfit list | grep -i aracodereturns the modelllmfit info "AraCode-7B-GGUF"shows correct params and quantization