This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update deploy step to use a specified Ubuntu image #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
reviewed
May 11, 2022
There was a problem hiding this comment.
Seems fine, unless broader changes might actually be needed down the line?
https://circleci.com/docs/2.0/configuration-reference/#deploy-deprecated
|
The unspecified image will be a problem by the end of the month, so we'll need to get this in before then. We can deal with |
sjspielman
approved these changes
May 19, 2022
|
The only way to test this is to merge it, so I'm going to do that without CI finishing. If the YAML was incorrectly formatted, I think we'd know by now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added the updates in #1224, I missed the deploy step.