Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Docker image 'housekeeping' to prepare for additional MCR versions #540

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

jaclyn-taroni
Copy link
Member

@jaclyn-taroni jaclyn-taroni commented Feb 14, 2020

Purpose/implementation Section

We're interested in adding other versions of MATLAB Compiler Runtime required for other methods to the project Docker image (#545, #546). Here I'm changing a folder name to potentially make things a bit cleaner/clearer down the road. I'm also removing some compressed files that were added to layers during installation.

What GitHub issue does your pull request address?

Related to #529

@jaclyn-taroni jaclyn-taroni changed the title WIP: MCR version required for FocalScan Docker image 'housekeeping' to prepare for additional MCR versions Feb 19, 2020
@jaclyn-taroni jaclyn-taroni marked this pull request as ready for review February 19, 2020 13:50
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Version numbers are good. (But how did you know R2014a was v83?)

@jaclyn-taroni
Copy link
Member Author

But how did you know R2014a was v83?

They tell you in the Release (MATLAB Runtime Version#) column here: https://www.mathworks.com/products/compiler/matlab-runtime.html

@jaclyn-taroni jaclyn-taroni merged commit 8a49217 into AlexsLemonade:master Feb 19, 2020
@jaclyn-taroni jaclyn-taroni deleted the install-focanscan branch February 19, 2020 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants