Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Remove R script/notebook package installs from snv-callers (Part 2 of N) #701

Merged

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented May 20, 2020

Purpose/implementation Section

What was your approach?

I'm removing R package installations in the scripts in accordance with #690
I'm keeping track of the PRs I file for that issue there.

This PR is me having going through snv-callers by its own because its a large one and has notebooks that require a lot of memory usage.

  • Removed package installs from compare_snv_callers_plots.Rmd and compare_snv_callers_plots-tcga.Rmd
  • Removed the VAF correlation plot from snv-callers, its very memory intensive and was crashing things out. Changed it to a table.
  • Changed the output file for pbta data plots to pbta-comparison so its more parallel to tcga-comparison.
  • Set up AWS instance.
  • Reran both notebooks.
  • Committed and pushed results files

Note that I'm ignoring the vaf_cutoff_experiment.Rmd notebook since it is deprecated.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Everything look okay? (Note this does not address #700 I'm looking into that separately).

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes, but the results shouldn't really be different.

Reproducibility Checklist

No changes are needed here.

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Copy link
Contributor

@cbethell cbethell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cansavvy! 👍

@jaclyn-taroni
Copy link
Member

It looks to me like there are some differences in the plots - any ideas why that might be? Are these portions of the snv-callers pipeline that didn't get rerun after some data release?

@cansavvy
Copy link
Collaborator Author

It looks to me like there are some differences in the plots - any ideas why that might be? Are these portions of the snv-callers pipeline that didn't get rerun after some data release?

Yes. The compare notebook (because it takes so much memory) doesn't automatically get run in the pipeline scripts, there's an option to turn it on or off:

So I think it been a tad since these notebooks got run fully.

@jaclyn-taroni jaclyn-taroni merged commit 608f7c5 into AlexsLemonade:master May 23, 2020
@cansavvy cansavvy deleted the snv-callers-compare-nb-re-run branch August 13, 2020 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants