This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Remove R script/notebook package installs from snv-callers
(Part 2 of N)
#701
Merged
jaclyn-taroni
merged 12 commits into
AlexsLemonade:master
from
cansavvy:snv-callers-compare-nb-re-run
May 23, 2020
Merged
Remove R script/notebook package installs from snv-callers
(Part 2 of N)
#701
jaclyn-taroni
merged 12 commits into
AlexsLemonade:master
from
cansavvy:snv-callers-compare-nb-re-run
May 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
reviewed
May 20, 2020
cbethell
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @cansavvy! 👍
It looks to me like there are some differences in the plots - any ideas why that might be? Are these portions of the |
Yes. The compare notebook (because it takes so much memory) doesn't automatically get run in the pipeline scripts, there's an option to turn it on or off:
So I think it been a tad since these notebooks got run fully. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What was your approach?
I'm removing R package installations in the scripts in accordance with #690
I'm keeping track of the PRs I file for that issue there.
This PR is me having going through
snv-callers
by its own because its a large one and has notebooks that require a lot of memory usage.compare_snv_callers_plots.Rmd
andcompare_snv_callers_plots-tcga.Rmd
pbta-comparison
so its more parallel totcga-comparison
.Note that I'm ignoring the
vaf_cutoff_experiment.Rmd
notebook since it is deprecated.Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Everything look okay? (Note this does not address #700 I'm looking into that separately).
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes, but the results shouldn't really be different.
Reproducibility Checklist
No changes are needed here.