Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue on Android - wasn't able to see incoming call when phone is locked \ app in background. #9

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

AlexBacich
Copy link

Android fixes:

  • While app is in background - popup wasn't showing at all. Fixed that.
  • While phone was locked - popup also didn't appear
  • Noticed that there is no need to programmatically detect whether app is in background or the screen is locked. The notification popup handles both scenarios. So removed unnecessary code.

Now things are working for Android.

@Alezhka
Copy link
Owner

Alezhka commented Dec 12, 2021

Thank you, but your PR touches too many different aspects of the code:
2. When app in background - popup didn't be to appear! Instead show call activity.
3. I think add variable for enable state is too much. Now ringtone enabled is not null.
4. I think use logger for production is not a good idea. Maybe need log level option for log printing. Need more think about it.
5. Too much code formatting and add/remove some spaces. (changes that do not affect the work of the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants