-
-
Notifications
You must be signed in to change notification settings - Fork 8k
fix: enhance file deletion handling and add option to hide uploading files and fix cloudreve refresh_token get error #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…files and fix cloudreve refresh_token get error
|
Walkthrough: This PR enhances the file deletion handling in the Cloudreve driver by implementing a retry mechanism for lock conflicts, adds an option to hide files currently being uploaded, and fixes the refresh token retrieval error. Additionally, it changes the HTTP method for a callback request. Changes:
|
| return nil | ||
| } | ||
|
|
||
| // 若存在锁冲突,则先清除锁再重试 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retry mechanism for lock conflicts in file deletion is a good addition. However, ensure that the error handling for the del() function is robust enough to handle unexpected errors beyond lock conflicts.
| return fmt.Errorf("up status: %d, error: %s", res.StatusCode, string(body)) | ||
| } | ||
|
|
||
| // 上传成功发送回调请求 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the HTTP method from POST to GET for the callback request might have implications on the server-side logic. Ensure that the server is configured to handle GET requests for this endpoint.
cloudreve 文件删除方法和修改refresh_token获取错误