feat: android 5 support #74
Draft
+168
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitadai31
reviewed
Feb 16, 2025
app/build.gradle.kts
Outdated
Comment on lines
-100
to
+104
| sourceCompatibility = JavaVersion.VERSION_11 | ||
| targetCompatibility = JavaVersion.VERSION_11 | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
You don't have to downgrade Java version
Even VERSION_17 can be used with minSdk 21
kotlinOptions.jvmTarget is too
|
By the way, are you still looking for a APK signing library that supports old Android? https://github.com/MuntashirAkon/apksig-android This apksig port supports Android <8, so it might be helpful |
I ported a custom V1 signer implementation in my last PR that I linked in this PR. |
Understood. Thank you for replying! |
wassa2133
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #45