Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding SHA256 so we can represent current ssb messages #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominictarr
Copy link

@dominictarr dominictarr commented Jun 18, 2019

I suggest adding sha256 format, so that current ssb messages are representable in binary using yamf-hash

@AljoschaMeyer
Copy link
Owner

Is it okay for you if we postpone this until we know whether ssb will actually need this?

@dominictarr
Copy link
Author

okay. obviously I havn't convinced you yet, but I am quite sure that we do actually need this

@dominictarr
Copy link
Author

btw, in the very first version, we did use blake2s ... we switched to sha256, because symmetric crypto is fast anyway, and sha256 is much more likely to be in standard libraries etc. Also, sha256 is fine. For a while, they were worried that sha256 was gonna weaken, like sha1 was, and held compettitions to find an heir (which sha3 won, and blake2 close but didn't get chosen) but after doing all that additional research, they understood sha256 better, and realized, actually it was okay.

@AljoschaMeyer
Copy link
Owner

No worries, I won't block this. I might however sneak in a breaking change and remove blake2, since nobody uses yamf-hash yet. In any case, this should wait until we decided on ssb's needs.

@dominictarr
Copy link
Author

Okay, lets wait until we've described upgrade paths and "what is scuttlebutt"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants