Skip to content

Conversation

amanape
Copy link
Member

@amanape amanape commented Sep 26, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.


Summarize what the PR does, explaining any non-trivial design decisions.

  • Precise LLM change detection to avoid blocking language-only saves
  • SaaS: call subscription validation only when LLM fields truly change
  • Tests updated to patch correct target and add regression for full-payload save

Link of any specific issues this addresses:


To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:4946d7d-nikolaik   --name openhands-app-4946d7d   docker.all-hands.dev/all-hands-ai/openhands:4946d7d

CLI with uvx:

uvx --python 3.12 --from git+https://github.com/All-Hands-AI/OpenHands@fix/llm-settings-validation-tdd openhands

…tests mirroring frontend full-payload behavior

- Precise LLM change detection to avoid blocking language-only saves
- SaaS: call subscription validation only when LLM fields truly change
- Tests updated to patch correct target and add regression for full-payload save

Co-authored-by: openhands <[email protected]>
@amanape amanape self-assigned this Sep 26, 2025
@amanape amanape added the deploy Deploy enterprise preview (internal use) label Sep 26, 2025
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  openhands/server
  settings_validation.py 58-92
Project Total  

This report was generated by python-coverage-comment-action

@openhands-agent
Copy link
Contributor

Feature deployment is available at: https://ohpr-11151.staging.all-hands.dev
Redirect URI for GitHub App is https://ohpr-11151.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint
Last updated: Sep 26, 2025, 12:56:14 PM ET

@amanape
Copy link
Member Author

amanape commented Sep 29, 2025

Closed by #11170

@amanape amanape closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy enterprise preview (internal use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants