fix: add provider tokens to resume conversation endpoint #11155
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Depends(get_provider_tokens) to /conversations/{id}/start endpoint
- Override empty tokens with real provider tokens
- Fixes 'Unable to access repo' error on conversation resume
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
malhotra5
reviewed
Sep 27, 2025
Comment on lines
+509
to
+510
| if provider_tokens: | ||
| conversation_init_data.git_provider_tokens = provider_tokens |
There was a problem hiding this comment.
Do we need to param providers_set if we already have the actual provider tokens?
I think they should always exists in saas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our SaaS resume conversation flow does not work for conversations with repositories. Logs show that we are populating ProviderTokens with empty values and eventually that leads to pods receiving empty provider dictionaries and raising errors because they cannot access repos. This is a potential code fix to:
It'd also be nice to clear out the empty provider token code that is not doing anything in this flow and add logs to alert on. For clarity, I'm leaving that out of this draft pr until the approach is reviewed and given a thumbs up to proceed.
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Link of any specific issues this addresses:
To run this PR locally, use the following command:
GUI with Docker:
CLI with uvx: