-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example usage of httpx #6325
Merged
Merged
Example usage of httpx #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Jan 22, 2025
async with httpx.AsyncClient() as client: | ||
response = await client.get('https://api.github.com/user', headers=headers) | ||
response.raise_for_status() # Raise an error for HTTP codes >= 400 | ||
json_response = JSONResponse(content=response.json()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructing a JSONResponse here is odd, but it looks like we were already doing it...
rbren
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
This PR updates the GitHub API integration to use
httpx
instead ofrequests
for making HTTP requests. This change improves the async support in our GitHub routes, making them more efficient and performant.Improved performance of GitHub API integration by using modern async HTTP client.
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR replaces the synchronous
requests
library with the asynchronoushttpx
library in our GitHub API integration routes. Key changes include:call_sync_from_async
by using native async HTTP callsLink of any specific issues this addresses
N/A
To run this PR locally, use the following command: