Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolver linting issues #6401

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix resolver linting issues #6401

merged 1 commit into from
Jan 23, 2025

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jan 21, 2025

This PR fixes several linting issues in the resolver code:

  • Add base_branch field to GithubIssue class to fix attr-defined error
  • Fix api_key type handling in LLMConfig instantiation by properly converting to str

All linting checks now pass for the resolver directory.

Part of #6397


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d48f0ed-nikolaik   --name openhands-app-d48f0ed   docker.all-hands.dev/all-hands-ai/openhands:d48f0ed

- Add base_branch field to GithubIssue class
- Fix api_key type handling in LLMConfig instantiation
@neubig neubig requested a review from malhotra5 January 21, 2025 21:16
@neubig neubig marked this pull request as ready for review January 21, 2025 21:19
Copy link
Contributor

@malhotra5 malhotra5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@neubig neubig merged commit 081a130 into main Jan 23, 2025
14 checks passed
@neubig neubig deleted the fix-resolver-lint branch January 23, 2025 23:21
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants