Feat/email #35
Merged
Feat/email #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- createdAt ์ ๋ฐ์ดํธ ๊ฐ๋ฅํ๋๋ก ์์ - expiresAt ๋ํ์ฉ ์ ๊ฑฐ
- ๋ง๋ฃ์๊ฐ๊ณผ ์ฝ๋ ๋ณ๊ฒฝ ๊ฐ๋ฅํ๋๋ก ์์ - ๋ง๋ฃ์๊ฐ์ด ์ง๋์ง ์์์ผ๋ฉด ์ธ์ฆ ๋ฒํธ ๋ฐ๊ธ ๋ถ๊ฐ -> ์ด๋ ์ถํ์ ์์ธ์ฒ๋ฆฌ ํ ์์
- Optional<Email> -> Email? ๋ก ์์ - ์์ธ ์ถ๊ฐ๋ก ์ธํด ์๋ก ์์ฑํ๋ ๊ฒฝ์ฐ๋ ์์ธ์ฒ๋ฆฌ ๋ผ์ธ์ผ๋ก ํ๊ฒ ๋จ -> ์ํ๊ฒ return์ผ๋ก ํด์ค - ์์ธ ์ฒ๋ฆฌ ์ถ๊ฐ
- ์ด๋ฉ์ผ ์ถ๊ฐ
- ์ด๋ฉ์ผ๊ณผ ์ธ์ฆ๋ฒํธ๊ฐ ๋ง๋ ๊ฒฝ์ฐ์๋ง isVerification์ด true๋ก ๋ณํ - apply ์ฌ์ฉ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก PULL REQUEST
#๏ธโฃ ์ฐ๊ด๋ ์ด์
๐ ์์ ๋ด์ฉ