Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/kotlin #97

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Refactor/kotlin #97

merged 12 commits into from
Sep 10, 2024

Conversation

rim109
Copy link
Contributor

@rim109 rim109 commented Sep 9, 2024 •
edited
Loading

πŸ’‘ PULL REQUEST

#️⃣ μ—°κ΄€λœ 이슈

#61 , #7 , #96 , #50

πŸ“ μž‘μ—… λ‚΄μš©

#61

  • κ²Œμ‹œλ¬Ό μ’‹μ•„μš”μ—μ„œ 총 κ²Œμ‹œλ¬Ό 수 μΆ”κ°€

#7

  • 총 λŒ“κΈ€ 수 μΆ”κ°€

#50

  • νšŒμ› νƒˆν‡΄ μ‚¬μœ  DTO
  • νƒˆν‡΄ μ‚¬μœ  μ΄λ„˜ 클래슀 μΆ”κ°€
  • νšŒμ› νƒˆν‡΄ μœ μ € μ—”ν‹°ν‹°, λ ˆν¬μ§€ν† λ¦¬ μΆ”κ°€
  • 기타 μ‚¬μœ λ©΄ reasonλ₯Ό 쓰도둝 μ˜ˆμ™Έμ²˜λ¦¬

#96

  • λ³€μˆ˜λͺ… μˆ˜μ •
  • 파일 이름 λ³€κ²½ (profile -> user둜)
  • 경둜(profile -> users둜, default-images -> default-image둜) μˆ˜μ •
  • ν™˜κ²½λ³€μˆ˜ ν”„λ‘ νŠΈ 배포된 μ£Όμ†Œλ‘œ λ³€κ²½
  • λΆˆν•„μš”ν•œ μ½”λ“œ μ‚­μ œ
  • μ€‘λ³΅λœ 쑰인을 λ°©μ§€ν•˜κΈ° μœ„ν•΄ λ¦¬νŒ©ν† λ§

생각해야 ν•˜λŠ” λΆ€λΆ„ ==> νƒˆν‡΄ν•  λ•Œ μ‚¬μœ λ₯Ό μΆ”κ°€ν•˜λ‹ˆκΉŒ μ²˜λ¦¬ν•˜λŠ” 속도가 λŠλ €μ‘Œλ‹€. κ°œμ„ ν•˜λŠ” 방법을 생각해야 함.

@rim109
βœ’οΈ Rename: profile -> user둜 μˆ˜μ • (#96)
bd19185 
- 폴더 μˆ˜μ •
- 클래슀 이름 μˆ˜μ •
- 그둜 μΈν•œ 폴더 이동
@rim109
πŸ› Fix: 경둜 μˆ˜μ • (#96)
ed41b18 
- 톡일성 λ§žμΆ°μ„œ μˆ˜μ •
- my-profile λ˜λŠ” profile이 μ•„λ‹ˆλΌ users둜 μˆ˜μ •
@rim109
πŸ› Fix: λ³€μˆ˜λͺ… μˆ˜μ • (#96)
4e324e5 
- ProfileId -> otherProfileId
@rim109
πŸ› Fix: 경둜 μˆ˜μ • (#96)
e942821 
- default-images -> default-image
@rim109
🍱 Add: κ²Œμ‹œλ¬Ό μ’‹μ•„μš” 쑰회 Res μΆ”κ°€ (#61)
2a2e78b
@rim109
🍱 Add: λŒ“κΈ€ μˆ˜μ • API μΆ”κ°€ (#7)
2fa2e25
@rim109
🍱 Add: λŒ“κΈ€ 총 수(totalCommentCount) μΆ”κ°€ (#7)
d812a63
@rim109
🍱 Add: μ’‹μ•„μš” μ‘°νšŒμ—μ„œ μ’‹μ•„μš”ν•œ κ²Œμ‹œλ¬Ό 총 수 μΆ”κ°€ (#61)
fc0f999
@rim109 rim109 added ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ (λ™μž‘ λ³€κ²½ μ—†μŒ) 🍱 Add 에셋 파일 μΆ”κ°€ kotlin Kotlin 배포 labels Sep 9, 2024
@rim109 rim109 requested a review from go-tiger September 9, 2024 23:16
@rim109 rim109 self-assigned this Sep 9, 2024
go-tiger
go-tiger approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@go-tiger go-tiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@rim109
🍱 Add: νšŒμ› νƒˆν‡΄ μ‚¬μœ  μΆ”κ°€ (#50)
ef7ae03 
- νšŒμ› νƒˆν‡΄ μ‚¬μœ  DTO
- νšŒμ› νƒˆν‡΄ μ‚¬μœ  μ΄λ„˜ 클래슀 μΆ”κ°€
- νšŒμ› νƒˆν‡΄ μœ μ € μ—”ν‹°ν‹°, λ ˆν¬μ§€ν† λ¦¬ μΆ”κ°€
- 기타 μ‚¬μœ λ©΄ reasonλ₯Ό 쓰도둝 μ˜ˆμ™Έμ²˜λ¦¬
@rim109
🧹 Remove: λΆˆν•„μš”ν•œ μ½”λ“œ μ‚­μ œ (#96)
594e2b5
@rim109
♻️ Refactor: 쀑볡 방지λ₯Ό μœ„ν•΄ λ¦¬νŒ©ν† λ§ (#96)
b674869
@rim109 rim109 merged commit b847bcb into dev Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@go-tiger go-tiger go-tiger approved these changes

Assignees

@rim109 rim109

Labels
🍱 Add 에셋 파일 μΆ”κ°€ kotlin Kotlin 배포 ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ (λ™μž‘ λ³€κ²½ μ—†μŒ)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rim109 @go-tiger