Add testing with ITC1600 #1900
Merged
Add testing with ITC1600 #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
t-b
force-pushed
the
feature/1900-add-testing-with-ITC1600
branch
from
7c60e0c to
cd91887
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
t-b
force-pushed
the
feature/1900-add-testing-with-ITC1600
branch
6 times, most recently
from
0522f0f to
4a9a3ed
Compare
t-b
added
the
PR:NeedsBackport
t-b
force-pushed
the
feature/1900-add-testing-with-ITC1600
branch
2 times, most recently
from
2d100f2 to
9c31cd1
Compare
In a future commit we want to introduce testing with ITC1600 so the current name is too general.
Only that is available on the test machine.
…for ITC1600 In 7dc07c7 (LNB: Save decimated stim set length for TTL channels, 2023-07-05) we changed the stored stimset lengths to be decimated. But the test assertion for ITC1600 was incorrectly adapted as the sampling interval is different for ITC1600.
…recedence This makes the code easier to understand.
These are in the range [0, 3] as well.
Mention that the channels are GUI channel numbers.
…hardware Since 2637e08 (Add channel types support to EpochsWave as chunk index, 2023-07-07) we have support for exporting epoch information of TTL channels into NWBv2. Unfortunately that commit failed to realize that we have to export TTL information per ttlBit for ITC hardware. As the tests were also wrong, this was found until now with the ITC1600 tests.
…s for ITC rack one This should catch errors better.
The current code did not correctly store the stimsets for ITC hardware if rack one is active with the ITC1600. As fixing it quickly would have made complicated code worse, we rewrote the TTL channel export to be hardware independent.
This was found in the test ExportIntoNWBSweepBySweep [1] and already reported upstream. [1]: https://github.com/AllenInstitute/MIES/actions/runs/6473820032/job/17577887259?pr=1900
… suffix generation in NWB Since 5f0f447 (NWB_AppendSweepLowLevel: Add support for TTL data from NI hardware, 2018-09-12) we don't use the ttlBit as channelSuffix anymore but 2^ttlBit. It is unclear at this point why this was changed. Introduce functions to convert between the two representations to avoid even more confusion in the future.
t-b
force-pushed
the
feature/1900-add-testing-with-ITC1600
branch
from
9c31cd1 to
b7afd53
Compare
|
@t-b, what's going on with the tests without status reports? i.e., Test ITC HardwareAnalysisFunctions and Test ITC HardwareBasic |
|
@timjarsky I've renamed the jobs from ITC to ITC18 and therefore the checks list is currently not complete. Once this PR is merged, I'll update that list. |
timjarsky
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Look into code, having [0, 7] would be nice.