Backport: Remove colon from job name #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a colon in the name makes it impossible to add the job to the branch rules. After consulting with github support, it seems renaming is the most straightforward solution.
t-b
changed the title
t-b
force-pushed
the
bugfix/2309-branch-protection-bug-backport
branch
3 times, most recently
from
abadc70 to
3a8595d
Compare
…release branch In c3e7dc3 (.github/workflows: Add job to compile test each commit, 2023-12-22) we introduced a compilation test of each commit in the branch. But we assumed that the base branch, the branch we want to merge into, is origin/main. This is not true for the release branches. As there is no way to gather the base branch for on.push workflows [1] we added some code to get the release branch with the highest version and then check if we are an ancestor of that or origin/main. [1]: https://github.com/orgs/community/discussions/26243#discussioncomment-3250924
t-b
force-pushed
the
bugfix/2309-branch-protection-bug-backport
branch
from
3a8595d to
dc29f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2308