Merge pull request #382 from AllenInstitute/bugfix/svgicon-build-size

bugfix/svgicon-build-size
AllenInstitute · Jan 7, 2025 · 1ad9c7c · 1ad9c7c
2 parents 719933e + e893bf0
commit 1ad9c7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/packages/core/components/FileThumbnail/index.tsx b/packages/core/components/FileThumbnail/index.tsx
@@ -45,10 +45,10 @@ export default function FileThumbnail(props: Props) {
     if (!props.uri) {
         return (
             <SvgIcon
-                height={props.height}
+                height={props?.height || 150}
                 pathData={NO_IMAGE_ICON_PATH_DATA}
                 viewBox="0,1,22,22"
-                width={props.width}
+                width={props?.width || 150}
                 className={classNames(styles.noThumbnail, {
                     [styles.noThumbnailSelected]: props?.selected,
                 })}

diff --git a/packages/core/components/SvgIcon/index.tsx b/packages/core/components/SvgIcon/index.tsx
@@ -1,5 +1,5 @@
 import classNames from "classnames";
-import { castArray, defaults } from "lodash";
+import { castArray } from "lodash";
 import * as React from "react";
 
 import styles from "./SvgIcon.module.css";
@@ -13,22 +13,12 @@ interface SvgIconProps {
     width?: number | string;
     viewBox: string;
 }
-
-// forwardRef components cannot make use of React's defaultProps mechanism
-const DEFAULT_PROPS = {
-    height: 15,
-    pathAttrs: {},
-    width: 15,
-};
-
 /**
  * A generalized SVG icon.
  */
 function SvgIcon(props: SvgIconProps, ref?: React.Ref<SVGSVGElement>) {
-    const { className, height, onClick, pathAttrs, pathData, viewBox, width } = defaults(
-        props,
-        DEFAULT_PROPS
-    );
+    const { className, height, onClick, pathAttrs = {}, pathData, viewBox, width } = props;
+
     return (
         <svg
             className={classNames({ [styles.interactive]: onClick !== undefined }, className)}