address linting errors

AllenInstitute · Feb 5, 2025 · f2d49cc · f2d49cc
1 parent b58858e
commit f2d49cc
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/core/components/EditMetadata/NewAnnotationPathway.tsx b/packages/core/components/EditMetadata/NewAnnotationPathway.tsx
@@ -47,6 +47,8 @@ interface AnnotationStatus {
  */
 export default function NewAnnotationPathway(props: NewAnnotationProps) {
     const dispatch = useDispatch();
+    // Destructure to prevent unnecessary useEffect triggers
+    const { onDismiss, hasUnsavedChanges } = props;
 
     const [step, setStep] = React.useState<EditStep>(EditStep.CREATE_FIELD);
     const [newValues, setNewValues] = React.useState<AnnotationValue | undefined>();
@@ -87,16 +89,16 @@ export default function NewAnnotationPathway(props: NewAnnotationProps) {
                                 message: `Failed to create annotation: ${e}`,
                             });
                         } finally {
-                            props?.hasUnsavedChanges(false);
-                            props.onDismiss();
+                            hasUnsavedChanges(false);
+                            onDismiss();
                         }
                     }
                 default:
                     return;
             }
         };
         checkForStatusUpdates();
-    }, [statuses, annotationCreationStatus, dispatch]);
+    }, [annotationCreationStatus, dispatch, hasUnsavedChanges, newFieldName, newValues, onDismiss]);
 
     const addDropdownChip = (evt: React.FormEvent) => {
         evt.preventDefault();