[Large] Create UI for metadata editing workflow #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswallace
requested review from
SeanLeRoy,
BrianWhitneyAI,
kmitcham,
pgarrison and
lynwilhelm
and removed request for
SeanLeRoy
BrianWhitneyAI
approved these changes
Nov 20, 2024
|
|
||
| import styles from "./EditMetadata.module.css"; | ||
|
|
||
| enum EditMetadataPathway { |
There was a problem hiding this comment.
Maybe const enum here
There was a problem hiding this comment.
is there a particular reason const enum would be needed for this one?
kmitcham
approved these changes
Nov 22, 2024
|
UX bugs from @lynwilhelm :
Global issues not specific to this ticket: |
SeanLeRoy
approved these changes
Nov 22, 2024
packages/core/components/EditMetadata/ExistingAnnotationPathway.tsx
Outdated
Show resolved
Hide resolved
| @@ -135,6 +136,24 @@ export default (filters?: FileFilter[], onDismiss?: () => void) => { | |||
| ], | |||
| }, | |||
| }, | |||
| ...(isQueryingAicsFms | |||
There was a problem hiding this comment.
Did you create a ticket for adding this capability for non-aics data sources? I think it wouldn't be very difficult to do via SQL like:
UPDATE ${datasourceName}
SET ${columnToUpdate} = ${valueToReplaceWith}
WHERE ${here either select by row number or the internally made BFF ID} = ${list of row numbers or bff ids}
There was a problem hiding this comment.
honestly I forgot we were planning to allow editing on non-aics data sources. Made ticket: #347
| const fileSelection = useSelector(selection.selectors.getFileSelection); | ||
| const fileCount = fileSelection.count(); | ||
| // Don't allow users to edit top level annotations (e.g., File Name) | ||
| const annotationOptions = useSelector(metadata.selectors.getSortedAnnotations) |
There was a problem hiding this comment.
Unsure why I have never attached JS array functions onto the selector like this... looks clean!
This was referenced Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the main part of the UI for editing file metadata from BFF based on the Figma designs. Does not include any backend logic.
Temporarily deployed to stagingPart of #96
Reviewing
Lots of changes with a slightly complicated file structure, so here's suggested review order:
There's also a brand new 'ComboBox' component (dropdown selector with search), which is a styled wrapper for the FluentUI combo box
To Dos (UI only)
Screenshots
Existing annotation pathway:
New annotation pathway: