Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ComboBox (dropdown) bugs #355

Conversation

aswallace
Copy link
Contributor

@aswallace aswallace commented Dec 7, 2024

Addresses the following bugs specific to the ComboBox (FluentUI's version of a dropdown with search)

  • When the dropdown options were open, using arrow keys to navigate the options also changed the file selection in the background (very bad!!)
  • Clicking inside & typing didn't open the menu by default. It now opens when you start typing (but not on click alone unfortunately)
  • Added styling in combobox menu for focus/active/selected
  • Searched item was not always appearing at the top of the search results. It now does unless it's the last item in the list

Also had to remove fuzzy search/fuse from the dropdown menu since it wasn't playing well with the built-in autocomplete, was not a requested feature, and was taking too long to make work.

closes #342

Styling for active/focused menu items (e.g., while hovering or using arrow keys to navigate)
image

@aswallace aswallace added the bug Something isn't working label Dec 7, 2024
@aswallace aswallace self-assigned this Dec 7, 2024
@aswallace aswallace linked an issue Dec 7, 2024 that may be closed by this pull request
7 tasks
@aswallace aswallace changed the title Feature/metadata editing/combobox bugs Fix ComboBox (dropdown) bugs Dec 7, 2024
@aswallace aswallace merged commit 861e40b into feature/metadata-editing/develop Dec 18, 2024
7 checks passed
@aswallace aswallace deleted the feature/metadata-editing/combobox-bugs branch December 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComboBox interaction bugs
3 participants