Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom build workflow #404

Merged
merged 2 commits into from
Feb 4, 2025
Merged

add custom build workflow #404

merged 2 commits into from
Feb 4, 2025

Conversation

BrianWhitneyAI
Copy link
Contributor

@BrianWhitneyAI BrianWhitneyAI commented Feb 4, 2025

Description

This PR adds a workflow to build a dist for a specific branch for a particular OS. This is useful if you have a bug that is os dependent but only have a dev setup of a specific OS.

@BrianWhitneyAI BrianWhitneyAI marked this pull request as ready for review February 4, 2025 20:51
@BrianWhitneyAI
Copy link
Contributor Author

I originally just appended the save artifacts portion of this workflow to our existing integration. This made the workflow pretty slow and store about 1 GB per run. I think this is too much to do per commit to a branch. This is a compromise to generate the artifacts for a specific situation instead.

.github/workflows/maunal-build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know how this will work with the two macos chip types? & if it will only work for m3 (since historically GH causes us issues with x86), unsure if that needs to be noted anywhere

@BrianWhitneyAI
Copy link
Contributor Author

Do we know how this will work with the two macos chip types? & if it will only work for m3 (since historically GH causes us issues with x86), unsure if that needs to be noted anywhere

I really want to iterate on this. ideally theres another option for different mac versions. I cant really run it easily until a base version of the workflow is merged to main

@BrianWhitneyAI BrianWhitneyAI merged commit d5655c5 into main Feb 4, 2025
7 checks passed
@BrianWhitneyAI BrianWhitneyAI deleted the feature/dev-build branch February 4, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants