bugfix/cache-modal-performance #411
Conversation
BrianWhitneyAI
requested review from
SeanLeRoy,
pgarrison,
kmitcham,
aswallace,
saeliddp,
tyler-foster and
hughes036
| const details = await fileSelection.fetchAllDetails(); | ||
| setFileDetails(details); | ||
| } catch (err: any) { | ||
| throw new Error(err.message || "Error fetching file details."); |
There was a problem hiding this comment.
This error won't get seen by a user in a useful manner. Having it be set to the component's state like you had earlier and then displaying the error would make this more useful
There was a problem hiding this comment.
I think your recent changes made some of my comments unnecessary.
I tested this in prod and was able to successfully open the modal with over 6,000 files selected. The #412/#408 bug prevented me from selecting more files.
I also uncovered a UI bug that I suspect was already in BFF. I'll file a new issue
| <FileTable files={filesNotInLocalCache} title="Files to download to VAST" /> | ||
| {loading && ( | ||
| <div className={styles.loading}> | ||
| <p>Loading file details...</p> |
There was a problem hiding this comment.
Thrilled to see this, I noticed the query time starts to get long even for hundreds of files, so this will really help users understand what's going on.
Description
The purpose of this PR is to resolve #409 and make the copy to local cache performant for 10,000+ files. This pr add a chunked response, waiting state and error handling around this process to make it smoother for users.
Testing
I tested this with the startup query date range that BFF has (with about 7,500 files) with no issues. Still investigating larger selections.