Enh/codeocean sdk #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjhardcastle @arjunsridhar12345 removed the typed dicts associated with the queue, please review when you have time. There's a lot of redundant code but I refactored out some of the redundancies. Factoring out all the redundancies seems like it goes out of the scope of this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from
aind-codeocean-apitocodeocean. We have redundant objects in the form ofJobStatusCapsuleComputationAPIthat we should consider refactoring out. Thecodeoceananalog provided isComputation. Some of our code relies onJobStatus,CapsuleComputationAPIbeing able to be iteratively serialized (all fields are optional) whereasComputationdoesn't allow for this (requires some values to be present for validation). We should consider how we want to change this. Either by using aComputationsubclass that allows us to do this or by changing the way we're creating/using these objects (ie: not iteratively serializing it). doctests for queue and codeocean_utils appear to be passing but we should identify what additional testing is necessary and perform it.