Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to Catch Validation Errors #158

Open
mekhlakapoor opened this issue Dec 1, 2023 · 0 comments
Open

Failing to Catch Validation Errors #158

mekhlakapoor opened this issue Dec 1, 2023 · 0 comments
Assignees

Comments

@mekhlakapoor
Copy link
Contributor

Describe the bug
The metadata service is returning the message Valid Model even for models that are expected to have validation errors (for ex when required fields are missing). Issue caught by @saskiad

To Reproduce
service returns "valid model" when required fields are missing
eg. http://aind-metadata-service/procedures/653980
This says the model is valid but there is no injection_volume field, which is a required field.
Expected behavior
should catch the validation errors for each of the procedure models and include that in message.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant