Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use model_construct #211

Open
7 tasks
mekhlakapoor opened this issue Mar 28, 2024 · 2 comments
Open
7 tasks

Don't use model_construct #211

mekhlakapoor opened this issue Mar 28, 2024 · 2 comments
Assignees

Comments

@mekhlakapoor
Copy link
Contributor

User story

As a developer, I want the pydantic models to validate correctly without recursion issues. Fix any model creations to not use model_construct

Acceptance criteria

  • Given procedures mappings, create models without model_construct

Sprint Ready Checklist

  • 1. Acceptance criteria defined
  • 2. Team understands acceptance criteria
  • 3. Team has defined solution / steps to satisfy acceptance criteria
  • 4. Acceptance criteria is verifiable / testable
  • 5. External / 3rd Party dependencies identified
  • 6. Ticket is prioritized and sized

Notes

Add any helpful notes here.

@mekhlakapoor
Copy link
Contributor Author

Check whether we can create invalid models with other method without it throwing validation errors at the time of creation

@jtyoung84
Copy link
Collaborator

We should try to create the model if possible, and if there are validation errors, we can use model_construct. But we should stop using model_construct as a default everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants