Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no pip in notty mode #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

no pip in notty mode #3

wants to merge 6 commits into from

Conversation

AllyW
Copy link
Owner

@AllyW AllyW commented Aug 27, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@@ -2,6 +2,11 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

  1. Added --no option to az vm repair create to skip prompt and confirm no to associating a public IP in NoTTY mode.
  2. Fixed bug with Public IP naming in NoTTY mode where the name was incorrectly set as a boolean instead of the expected format.
  3. Removed references to the unlock_singlepass_encrypted_disk function.
  4. Improved logging and code formatting throughout the codebase.
  5. Updated the reset_nic function to correctly handle application security group names and ensure IP address updates.
  6. Enhanced error handling by raising more specific exceptions in certain cases.

++++++
Added --no to az vm repair create.
Fixed bug with Public IP naming in NoTTY mode. Name was a boolean instead of repair-<vm>-PublicIp

1.0.8
++++++
SELFHELP telemetry added as initiator. Extra parameters is introduced at the backend to capture the telemetry data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.9
+++++++

  • Added --no to az vm repair create.
  • Fixed bug with Public IP naming in NoTTY mode. Name was a boolean instead of repair-<vm>-PublicIp.

1.0.8
+++++++

  • SELFHELP telemetry added as initiator. Additional parameters introduced at the backend to capture telemetry data.

Copy link

Hi @AllyW

Release Suggestions

Module: vm-repair

  • Update VERSION to 1.1.0 in src/vm-repair/setup.py

Notes

@AllyW AllyW force-pushed the main branch 2 times, most recently from 7e9bcf3 to 087db12 Compare August 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants