forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no pip in notty mode #3
Open
AllyW
wants to merge
6
commits into
main
Choose a base branch
from
jimurrito-noPip-in-notty-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+43
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the subscription id for reset_nic()
… changes to control flow, and disabled generic Pylint errors on un-used code.
src/vm-repair/HISTORY.rst
Outdated
@@ -2,6 +2,11 @@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary:
- Added
--no
option toaz vm repair create
to skip prompt and confirm no to associating a public IP in NoTTY mode. - Fixed bug with Public IP naming in NoTTY mode where the name was incorrectly set as a boolean instead of the expected format.
- Removed references to the
unlock_singlepass_encrypted_disk
function. - Improved logging and code formatting throughout the codebase.
- Updated the
reset_nic
function to correctly handle application security group names and ensure IP address updates. - Enhanced error handling by raising more specific exceptions in certain cases.
++++++ | ||
Added --no to az vm repair create. | ||
Fixed bug with Public IP naming in NoTTY mode. Name was a boolean instead of repair-<vm>-PublicIp | ||
|
||
1.0.8 | ||
++++++ | ||
SELFHELP telemetry added as initiator. Extra parameters is introduced at the backend to capture the telemetry data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.9
+++++++
- Added --no to
az vm repair create
. - Fixed bug with Public IP naming in NoTTY mode. Name was a boolean instead of
repair-<vm>-PublicIp
.
1.0.8
+++++++
- SELFHELP telemetry added as initiator. Additional parameters introduced at the backend to capture telemetry data.
Hi @AllyW Release SuggestionsModule: vm-repair
Notes
|
AllyW
force-pushed
the
main
branch
2 times, most recently
from
August 30, 2024 08:14
7e9bcf3
to
087db12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.